WorldForge Community

"marc" said:

Hi.

I've tried building the Worldforge tools and libraries on a system with GCC 4.3 as default compiler. There are a few things that need some code changes, otherwise the software won't compile.

In most cases it was just missing include files, which have been restructured in GCC 4.3 to speed up compile and preprocessing time. Some other problems were duplicate function parameters in prototypes. A porting guide can be found here.

I did the following small changes, after which the libraries compiled fine with 4.3, and since those changes are backwards-compatible, they compiled fine with GCC 3.4.6, too.

Skstream:
skstream.cpp
+ #include <cstring>

skserver.cpp
+ #include <cstring>


Atlas-C++:
Filter.cpp
+ #include <cstring>

tools/atlas_convert.cpp
+ #include <cstdlib>


Wfmath:
no changes needed to be done


Varconf:
variable.cpp
+ #include <cstdlib>


Mercator:
RandCache.h
+ #include <cstdlib>

AreaShader.cpp
+ #include <algorithm>

AreaShader.h
- void shadeArea(Surface& s, const Area* const s) const;
+ void shadeArea(Surface& s, const Area* const ar) const;


Eris:
Exceptions.h
- InvalidAtlas(const std::string& msg, const Atlas::Message::Element& msg);
+ InvalidAtlas(const std::string& msg, const Atlas::Message::Element& el);

Connection.h
+ #include <memory>

Account.h
+ #include <memory>

Metaserver.h
+ #include <memory>

Metaserver.cpp
+ #include <cstring>

EntityRef.h
+ #include <string>

test/metaQuery.cpp
+ #include <algorithm>


libwfut:
platform.cpp
+ #include <algorithm>


Those are all the needed changes to get them compile with 4.3. I didn't try the server and clients yet, which I might do during the next days.
What is the preferred communication channel for something like this or for sending patches? Is it fine to use this forum or should I use the mailing list? In launchpad aren't all libraries registered yet, where someone could open a bug or so.